Fix crash in broadcaster max price calculation.#3864
Merged
Conversation
Usually there are constraints in place alongside the capabilities in order to set a per-capability price. However, if no constraints are set, there are no per-capability prices, so return the global max price instead. This hasn't come up in prod (and fixes a crash) so shouldn't be a breaking change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3864 +/- ##
===================================================
+ Coverage 32.16326% 32.17139% +0.00813%
===================================================
Files 170 170
Lines 41308 41310 +2
===================================================
+ Hits 13286 13290 +4
+ Misses 27021 27020 -1
+ Partials 1001 1000 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually there are constraints in place alongside the capabilities in order to set a per-capability price. However, if no constraints are set, there are no per-capability prices, so return the global max price instead.
This hasn't come up in prod (and fixes a crash) so shouldn't be a breaking change.